Bug 118403 - [Coordinated Graphics] Rename variables in UpdateAtlas
Summary: [Coordinated Graphics] Rename variables in UpdateAtlas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 18:45 PDT by Jae Hyun Park
Modified: 2013-07-08 07:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2013-07-04 18:46 PDT, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2013-07-07 18:59 PDT, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (489.37 KB, application/zip)
2013-07-07 21:41 PDT, Build Bot 		no flags Details
Patch (2.96 KB, patch)
2013-07-08 00:52 PDT, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2013-07-04 18:45:19 PDT 
As of r149292, non-composited contents layer was removed from CoordinatedGraphics. So, the variable names should be updated for clarification.
Comment 1 Jae Hyun Park 2013-07-04 18:46:51 PDT 
Created attachment 206118 [details]
Patch
Comment 2 Jae Hyun Park 2013-07-07 18:59:06 PDT 
Created attachment 206213 [details]
Patch
Comment 3 Build Bot 2013-07-07 21:41:55 PDT 
Comment on attachment 206213 [details]
Patch

Attachment 206213 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/970123

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html
Comment 4 Build Bot 2013-07-07 21:41:56 PDT 
Created attachment 206216 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 5 Jae Hyun Park 2013-07-07 21:46:11 PDT 
The new failing test is not related to this patch.
Comment 6 Noam Rosenthal 2013-07-08 00:25:20 PDT 
Comment on attachment 206213 [details]
Patch

Please call it RootContentsLayer
Comment 7 Jae Hyun Park 2013-07-08 00:52:41 PDT 
Created attachment 206222 [details]
Patch
Comment 8 Jae Hyun Park 2013-07-08 01:10:56 PDT 
(In reply to comment #6)
> (From update of attachment 206213 [details])
> Please call it RootContentsLayer

Thanks for the review. I updated the patch.
Comment 9 WebKit Commit Bot 2013-07-08 07:13:28 PDT 
Comment on attachment 206222 [details]
Patch

Clearing flags on attachment: 206222

Committed r152450: <http://trac.webkit.org/changeset/152450>
Comment 10 WebKit Commit Bot 2013-07-08 07:13:31 PDT 
All reviewed patches have been landed.  Closing bug.