Bug 118392 – [EFL][WK2] Implement unit test callbacks: onWordLearn and onWordIgnore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Krzysztof Wolanski]

Simulate behavior of Learn and Ignore Word in the text field.

[Krzysztof Wolanski]

Created attachment 206084 [details]
proposed patch

[Chris Dumez]

Comment on attachment 206084 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206084&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:807
> +    knownWord = "";

knownWord = String()?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:839
> +    knownWord = "";

knownWord = String()?

[Mikhail Pozdnyakov]

Comment on attachment 206084 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206084&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:55
> +String knownWord;

why not static?

>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:807
>> +    knownWord = "";
> 
> knownWord = String()?

emptyString() ?

[Krzysztof Wolanski]

Created attachment 206088 [details]
apply suggestions

[Chris Dumez]

> >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:807
> >> +    knownWord = "";
> > 
> > knownWord = String()?
> 
> emptyString() ?

Right, emptyString() is better indeed.

[Chris Dumez]

Why no review flag?

[Krzysztof Wolanski]

Created attachment 206090 [details]
apply suggestions

[Chris Dumez]

Comment on attachment 206090 [details]
apply suggestions

Ok, r=me but please let Grzegorz have a look before landing.

[Grzegorz Czajkowski]

Comment on attachment 206090 [details]
apply suggestions

View in context: https://bugs.webkit.org/attachment.cgi?id=206090&action=review

I'd love to see it in the trunk. Added one comments regarding to the spellchecking and one nit.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:188
> +    *misspellingLength = static_cast<int32_t>(knownWord.length());

As I understand correctly, this callback should treat known words as spelled correctly. Therefore, its length should be set to 0 to notify WebCore to don't create spelling marker for it. Additionally, the location should be set to -1 according to the doc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:813
> +    mouseDoubleClick(10, 20, 1 /* Left button */);

Can we skip left button value and this comment here? mouseDoubleClick passes left button implicitly.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:845
> +    mouseDoubleClick(10, 20, 1 /* Left button */);

Ditto.

[Krzysztof Wolanski]

Created attachment 206127 [details]
apply suggestions

[Grzegorz Czajkowski]

Comment on attachment 206127 [details]
apply suggestions

Thanks

[WebKit Commit Bot]

Comment on attachment 206127 [details]
apply suggestions

Clearing flags on attachment: 206127

Committed r152414: <http://trac.webkit.org/changeset/152414>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.