Bug 118387 - Change static_cast<SVGImageElement*> with toSVGImageElement
Summary: Change static_cast<SVGImageElement*> with toSVGImageElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 02:33 PDT by Gyuyoung Kim
Modified: 2013-07-04 18:36 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2013-07-04 02:37 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-07-04 02:33:17 PDT
As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can be changed with toSVGImageElement().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557
Comment 1 Gyuyoung Kim 2013-07-04 02:37:29 PDT
Created attachment 206069 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-04 06:58:59 PDT
Comment on attachment 206069 [details]
Patch

Clearing flags on attachment: 206069

Committed r152399: <http://trac.webkit.org/changeset/152399>
Comment 3 WebKit Commit Bot 2013-07-04 06:59:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2013-07-04 08:27:07 PDT
(In reply to comment #2)
> (From update of attachment 206069 [details])
> Clearing flags on attachment: 206069
> 
> Committed r152399: <http://trac.webkit.org/changeset/152399>

It broke the debug builds:
In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0:
/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)':
[1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m
Comment 5 Chris Dumez 2013-07-04 08:34:42 PDT
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 206069 [details] [details])
> > Clearing flags on attachment: 206069
> > 
> > Committed r152399: <http://trac.webkit.org/changeset/152399>
> 
> It broke the debug builds:
> In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0:
> /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)':
> [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m

Build fix landed in <http://trac.webkit.org/changeset/152400>.
Comment 6 Gyuyoung Kim 2013-07-04 18:36:45 PDT
(In reply to comment #5)

> Build fix landed in <http://trac.webkit.org/changeset/152400>.

I missed to add it. Thank you for the fixing.