Bug 118381 - [GTK] gtk_icon_info_free is deprecated since GTK+ 3.8
Summary: [GTK] gtk_icon_info_free is deprecated since GTK+ 3.8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2013-07-04 01:24 PDT by Iago Toral
Modified: 2020-04-07 02:47 PDT (History)
3 users (show)

See Also:

Attachments
Proposed (1.57 KB, patch)
2013-07-04 01:32 PDT, Iago Toral 		no flags Details | Formatted Diff | Diff
Patch (2.31 KB, patch)
2020-04-07 02:19 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iago Toral 2013-07-04 01:24:47 PDT 
gtk_icon_info_free has been deprecated in favor of g_object_unref. I'll attach patch shortly.
Comment 1 Iago Toral 2013-07-04 01:32:47 PDT 
Created attachment 206062 [details]
Proposed
Comment 2 Carlos Garcia Campos 2013-07-04 01:42:21 PDT 
Comment on attachment 206062 [details]
Proposed

We can't do this, we depend on GTK+ 3.6, where GtkIconInfo is not a GObject but a boxed type. We need to add an #ifdef until we bump the required version to 3.8, or we can simply ignore deprecated symbols in gtk versions grater than 3.6. I even proposed a patch to remove the annoying warnings for those cases indeed, see bug #118237.
Comment 3 Claudio Saavedra 2020-04-07 02:19:23 PDT 
Created attachment 395665 [details]
Patch
Comment 4 EWS 2020-04-07 02:47:42 PDT 
Committed r259631: <https://trac.webkit.org/changeset/259631>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395665 [details].