Bug 118379 - [EFL] Gardening. Unskip tests related with editing
Summary: [EFL] Gardening. Unskip tests related with editing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 00:00 PDT by KyungTae Kim
Modified: 2013-07-04 02:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2013-07-04 00:14 PDT, KyungTae Kim
no flags Details | Formatted Diff | Diff
Patch for landing (15.76 KB, patch)
2013-07-04 01:08 PDT, KyungTae Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2013-07-04 00:00:43 PDT
Passed after 150289:
editing/selection/doubleclick-beside-cr-span.html
editing/selection/doubleclick-whitespace.html

Passed after 151626:
editing/style/5065910.html
Comment 1 KyungTae Kim 2013-07-04 00:14:26 PDT
Created attachment 206056 [details]
Patch
Comment 2 Chris Dumez 2013-07-04 00:26:02 PDT
Comment on attachment 206056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review

> LayoutTests/platform/efl/TestExpectations:-470
> -editing/style/5065910.html [ Missing ]

The expected result for this test is wrong. I did not check the others but please do.
Comment 3 KyungTae Kim 2013-07-04 00:48:06 PDT
Comment on attachment 206056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review

>> LayoutTests/platform/efl/TestExpectations:-470
>> -editing/style/5065910.html [ Missing ]
> 
> The expected result for this test is wrong. I did not check the others but please do.

You're right. The expected result is wrong because 'paste' is not supported for EFL port now.
In this case, should we remain it as 'Missing' and remove the expected result for that?
Comment 4 Chris Dumez 2013-07-04 00:56:02 PDT
Comment on attachment 206056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review

>>> LayoutTests/platform/efl/TestExpectations:-470
>>> -editing/style/5065910.html [ Missing ]
>> 
>> The expected result for this test is wrong. I did not check the others but please do.
> 
> You're right. The expected result is wrong because 'paste' is not supported for EFL port now.
> In this case, should we remain it as 'Missing' and remove the expected result for that?

Yes, let's remove the wrong expected result.
Comment 5 Chris Dumez 2013-07-04 00:56:56 PDT
FYI, such patch don't need review, just cq. You can remove the "Reviewed By" line from the changelog and set cq flag only.
Comment 6 KyungTae Kim 2013-07-04 01:08:33 PDT
Created attachment 206059 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-07-04 02:05:51 PDT
Comment on attachment 206059 [details]
Patch for landing

Clearing flags on attachment: 206059

Committed r152394: <http://trac.webkit.org/changeset/152394>
Comment 8 WebKit Commit Bot 2013-07-04 02:05:55 PDT
All reviewed patches have been landed.  Closing bug.