Bug 118372 - Simplify PageThrottler ownership.
Summary: Simplify PageThrottler ownership.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-03 16:33 PDT by Gavin Barraclough
Modified: 2013-07-03 17:03 PDT (History)
3 users (show)

See Also:


Attachments
Fix (4.29 KB, patch)
2013-07-03 16:41 PDT, Gavin Barraclough
barraclough: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
qt fix (4.31 KB, patch)
2013-07-03 16:54 PDT, Gavin Barraclough
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-07-03 16:33:22 PDT
PageThrottler is currently ref counted, but it's lifetime is actually tied to Page – should just be an owned relationship.
Comment 1 Gavin Barraclough 2013-07-03 16:41:23 PDT
Created attachment 206034 [details]
Fix
Comment 2 Early Warning System Bot 2013-07-03 16:50:11 PDT
Comment on attachment 206034 [details]
Fix

Attachment 206034 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1024206
Comment 3 EFL EWS Bot 2013-07-03 16:51:11 PDT
Comment on attachment 206034 [details]
Fix

Attachment 206034 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1024208
Comment 4 Early Warning System Bot 2013-07-03 16:52:36 PDT
Comment on attachment 206034 [details]
Fix

Attachment 206034 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1015848
Comment 5 Gavin Barraclough 2013-07-03 16:54:14 PDT
Created attachment 206036 [details]
qt fix
Comment 6 Gavin Barraclough 2013-07-03 16:56:08 PDT
Comment on attachment 206036 [details]
qt fix

r+ from Sam
Comment 7 Gavin Barraclough 2013-07-03 17:03:59 PDT
Committed revision 152384.