Bug 118370 - [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available.
Summary: [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Viatcheslav Ostapenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-03 13:32 PDT by Viatcheslav Ostapenko
Modified: 2013-07-04 23:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2013-07-03 13:41 PDT, Viatcheslav Ostapenko
no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2013-07-03 14:10 PDT, Viatcheslav Ostapenko
no flags Details | Formatted Diff | Diff
Patch for landing (1.52 KB, patch)
2013-07-04 22:58 PDT, Viatcheslav Ostapenko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2013-07-03 13:32:40 PDT
Should have fallback like WK2 test runner has.
Comment 1 Viatcheslav Ostapenko 2013-07-03 13:41:30 PDT
Created attachment 206021 [details]
Patch
Comment 2 Viatcheslav Ostapenko 2013-07-03 14:10:32 PDT
Created attachment 206024 [details]
Patch
Comment 3 Chris Dumez 2013-07-03 21:34:13 PDT
Comment on attachment 206024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206024&action=review

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:438
>      const char* engine = 0;

The engine here can be moved inside the #ifdef.
Comment 4 Chris Dumez 2013-07-03 21:34:50 PDT
Comment on attachment 206024 [details]
Patch

Please fix the nit before landing.
Comment 5 Chris Dumez 2013-07-03 21:44:21 PDT
Comment on attachment 206024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206024&action=review

>> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:438
>>      const char* engine = 0;
> 
> The engine here can be moved inside the #ifdef.

We actually don't even need this variable. We can simply pass ""opengl_x11" to ecore_evas_new().
Comment 6 Viatcheslav Ostapenko 2013-07-04 22:58:52 PDT
Created attachment 206123 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-07-04 23:54:16 PDT
Comment on attachment 206123 [details]
Patch for landing

Clearing flags on attachment: 206123

Committed r152408: <http://trac.webkit.org/changeset/152408>
Comment 8 WebKit Commit Bot 2013-07-04 23:54:19 PDT
All reviewed patches have been landed.  Closing bug.