RESOLVED FIXED 118368
Nix upstreaming - Adding Nix render theme files 
https://bugs.webkit.org/show_bug.cgi?id=118368
Summary Nix upstreaming - Adding Nix render theme files
Marcelo Lira
Reported 2013-07-03 12:57:28 PDT
All files related to render theme stuff.
Attachments
Patch (25.34 KB, patch)
2013-07-03 14:14 PDT, Tullio Lucena 		no flags
DetailsFormatted DiffDiff
Patch (25.47 KB, patch)
2013-07-05 15:00 PDT, Tullio Lucena 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tullio Lucena
Comment 1 2013-07-03 14:14:37 PDT
Created attachment 206025 [details] Patch
Benjamin Poulain
Comment 2 2013-07-05 14:22:48 PDT
Comment on attachment 206025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206025&action=review Use real name: o-> renderObject. i->info|paintInfo. > Source/WebCore/platform/nix/RenderThemeNix.cpp:276 > +void RenderThemeNix::adjustProgressBarStyle(StyleResolver*, RenderStyle* style, Element *) const Element * -> Element* > Source/WebCore/platform/nix/RenderThemeNix.h:33 > +class RenderThemeNix : public RenderTheme { Plenty of missing OVERRIDE. > Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:29 > +#include "NotImplemented.h" Why? > Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:30 > +#include <stdio.h> Why? > Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:46 > + return 0; // we paint on top Fix the comment. > Source/WebCore/platform/nix/ScrollbarThemeNix.h:33 > +class ScrollbarThemeNix : public ScrollbarTheme { Missing OVERRIDEs.
Tullio Lucena
Comment 3 2013-07-05 15:00:15 PDT
Created attachment 206171 [details] Patch
Tullio Lucena
Comment 4 2013-07-05 15:10:23 PDT
Thanks for the review. I have updated the patch. Could you give a cq+?
WebKit Commit Bot
Comment 5 2013-07-05 16:06:52 PDT
Comment on attachment 206171 [details] Patch Clearing flags on attachment: 206171 Committed r152428: <http://trac.webkit.org/changeset/152428>
WebKit Commit Bot
Comment 6 2013-07-05 16:06:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.