[WK2][GTK] Invalid ASSERTs in WebResources loading code

[Sergio Villar Senin]

The WebKitWebView keeps track of the resources being loaded in a map that is cleared each time a new load starts. As it's using the injected bundle API to track resource loads it might happen (specially when running webkit under valgrind) that we get notifications for resources that correspond to previous page loads.

We need to remove those ASSERTs as they're no longer correct.

[Sergio Villar Senin]

Created attachment 205992 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 205992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205992&action=review

You are absolutely right, but I'm not sure about the second assert. Thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:-1632
> -    ASSERT(priv->loadingResourcesMap.contains(resourceIdentifier));

I'm not sure about this one, this method is always called after webkitWebViewGetLoadingWebResource() only when we have a valid pointer.

[Sergio Villar Senin]

Committed r152354: <http://trac.webkit.org/changeset/152354>