Bug 118350 - Gif: zero filling should use memset instead of setRGBA for every pixel
Summary: Gif: zero filling should use memset instead of setRGBA for every pixel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-03 03:45 PDT by Balazs Kelemen
Modified: 2013-07-03 06:55 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.48 KB, patch)
2013-07-03 04:46 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2013-07-03 03:45:32 PDT
GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels. This is extremely ineffecient. The use case for this code path is not frequent on the web but it's still better to fix.
Comment 1 Balazs Kelemen 2013-07-03 04:46:46 PDT
Created attachment 205993 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-03 06:55:30 PDT
Comment on attachment 205993 [details]
Patch

Clearing flags on attachment: 205993

Committed r152352: <http://trac.webkit.org/changeset/152352>
Comment 3 WebKit Commit Bot 2013-07-03 06:55:31 PDT
All reviewed patches have been landed.  Closing bug.