Bug 118345 - [GTK] webkit_set_cache_model is not turning the cache off
Summary: [GTK] webkit_set_cache_model is not turning the cache off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-03 02:26 PDT by Tomas Popela
Modified: 2013-07-08 22:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2013-07-03 02:37 PDT, Carlos Garcia Campos 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2013-07-03 02:26:48 PDT 
When using webkit_set_cache_model (WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER), WebKit should disable the cache completely. Now it is not disabled properly.
Comment 1 Carlos Garcia Campos 2013-07-03 02:29:13 PDT 
Yes, this is because setting the cache capacities to 0 doesn't disable the cache, capacities are only used when pruning the cache, but when adding new resources only whether the cache is enabled is checked.
Comment 2 Carlos Garcia Campos 2013-07-03 02:37:59 PDT 
Created attachment 205984 [details]
Patch
Comment 3 Sergio Villar Senin 2013-07-03 05:00:35 PDT 
Comment on attachment 205984 [details]
Patch

Great!
Comment 4 Carlos Garcia Campos 2013-07-08 22:40:21 PDT 
Committed r152483: <http://trac.webkit.org/changeset/152483>