Bug 118339 - fourthTier: DFG should refer to BasicBlocks by BasicBlock* and not BlockIndex
Summary: fourthTier: DFG should refer to BasicBlocks by BasicBlock* and not BlockIndex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 118340
Blocks: 118338
  Show dependency tree / graph
 
Reported: 2013-07-02 21:58 PDT by Filip Pizlo
Modified: 2013-07-05 18:02 PDT (History)
7 users (show)

See Also:

Attachments
work in progress (49.92 KB, patch)
2013-07-03 19:11 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (75.77 KB, patch)
2013-07-03 19:58 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (85.53 KB, patch)
2013-07-03 22:22 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
moar!! (121.51 KB, patch)
2013-07-04 09:20 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
almost done, I think (139.15 KB, patch)
2013-07-04 09:36 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
it compiles (161.37 KB, patch)
2013-07-04 12:01 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
it runs programs (162.39 KB, patch)
2013-07-04 12:15 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (162.40 KB, patch)
2013-07-04 13:58 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-02 21:58:34 PDT 
More fun.
Comment 1 Filip Pizlo 2013-07-03 19:11:15 PDT 
Created attachment 206043 [details]
work in progress
Comment 2 Filip Pizlo 2013-07-03 19:58:47 PDT 
Created attachment 206048 [details]
more
Comment 3 Filip Pizlo 2013-07-03 22:22:46 PDT 
Created attachment 206050 [details]
more
Comment 4 Filip Pizlo 2013-07-04 09:20:34 PDT 
Created attachment 206097 [details]
moar!!
Comment 5 Filip Pizlo 2013-07-04 09:36:32 PDT 
Created attachment 206098 [details]
almost done, I think
Comment 6 Filip Pizlo 2013-07-04 12:01:31 PDT 
Created attachment 206108 [details]
it compiles
Comment 7 Filip Pizlo 2013-07-04 12:15:08 PDT 
Created attachment 206110 [details]
it runs programs
Comment 8 Filip Pizlo 2013-07-04 13:58:08 PDT 
Created attachment 206112 [details]
the patch

No performance regression.
Comment 9 Michael Saboff 2013-07-05 16:03:03 PDT 
Comment on attachment 206112 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206112&action=review

> Source/JavaScriptCore/dfg/DFGDominators.h:53
> +    }

Add an empty line between methods.
Comment 10 Filip Pizlo 2013-07-05 18:02:04 PDT 
Landed in http://trac.webkit.org/changeset/152431