Bug 118337 - Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
Summary: Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 19:48 PDT by Simon Fraser (smfr)
Modified: 2013-07-24 14:53 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2013-07-02 19:57 PDT, Simon Fraser (smfr)
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-07-02 19:48:59 PDT
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
Comment 1 Simon Fraser (smfr) 2013-07-02 19:57:09 PDT
Created attachment 205964 [details]
Patch
Comment 2 Benjamin Poulain 2013-07-02 20:01:56 PDT
Comment on attachment 205964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205964&action=review

> Source/WebCore/css/StyleResolver.cpp:1534
> +    if ((isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())) && style->useTouchOverflowScrolling())

Can you move style->useTouchOverflowScrolling() to be the first condition? (for readability).
Comment 3 Simon Fraser (smfr) 2013-07-02 20:22:24 PDT
http://trac.webkit.org/changeset/152335
Comment 4 Daniel Bates 2013-07-24 14:53:07 PDT
(In reply to comment #3)
> http://trac.webkit.org/changeset/152335

This regressed both the rendering and the ability to scroll on <http://www.apple.com/mac-pro/index1.html>. See bug #119066 for more details.