Bug 118333 - REGRESSION(r152318): This patch broke media/track/track-automatic-subtitles.html on Mac (Requested by dfarler on #webkit).
Summary: REGRESSION(r152318): This patch broke media/track/track-automatic-subtitles.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 118319
  Show dependency tree / graph
 
Reported: 2013-07-02 17:27 PDT by WebKit Commit Bot
Modified: 2013-07-02 17:49 PDT (History)
5 users (show)

See Also:

Attachments
ROLLOUT of r152318 (6.49 KB, patch)
2013-07-02 17:27 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-07-02 17:27:28 PDT 
http://trac.webkit.org/changeset/152318 broke the build:
This patch broke media/track/track-automatic-subtitles.html on Mac (Requested by dfarler on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Commit Bot 2013-07-02 17:27:49 PDT 
Created attachment 205959 [details]
ROLLOUT of r152318

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 David Farler 2013-07-02 17:33:46 PDT 
Comment on attachment 205959 [details]
ROLLOUT of r152318

Rolling out.
Comment 3 WebKit Commit Bot 2013-07-02 17:33:59 PDT 
Comment on attachment 205959 [details]
ROLLOUT of r152318

Rejecting attachment 205959 [details] from commit-queue.

dfarler@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 David Farler 2013-07-02 17:37:37 PDT 
Just added myself to contributors.json. I'll try again in a moment.
Comment 5 David Farler 2013-07-02 17:46:23 PDT 
Comment on attachment 205959 [details]
ROLLOUT of r152318

Ok, let's try this again.
Comment 6 WebKit Commit Bot 2013-07-02 17:49:23 PDT 
Comment on attachment 205959 [details]
ROLLOUT of r152318

Clearing flags on attachment: 205959

Committed r152333: <http://trac.webkit.org/changeset/152333>
Comment 7 WebKit Commit Bot 2013-07-02 17:49:25 PDT 
All reviewed patches have been landed.  Closing bug.