Bug 118325 - EGL and GLES files need to be included in Windows build
Summary: EGL and GLES files need to be included in Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 14:39 PDT by Alex Christensen
Modified: 2013-07-02 17:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.52 KB, patch)
2013-07-02 14:42 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-02 14:39:43 PDT 
Windows builds of WebGL need EGL symbols from GLContextEGL.cpp.  Also, GraphicsContext3DOpenGL.cpp should be removed in favor of GraphicsContext3DOpenGLES.cpp to use with ANGLE's GLES implementation.
Comment 1 Alex Christensen 2013-07-02 14:42:26 PDT 
Created attachment 205944 [details]
Patch
Comment 2 Brent Fulgham 2013-07-02 16:56:32 PDT 
Comment on attachment 205944 [details]
Patch

I was going to ask if we needed to exclude the GLContextEGL.cpp file for now, but I see that it is protected by an USE(EGL) guard in the cpp file.

r=me.
Comment 3 WebKit Commit Bot 2013-07-02 17:19:22 PDT 
Comment on attachment 205944 [details]
Patch

Clearing flags on attachment: 205944

Committed r152329: <http://trac.webkit.org/changeset/152329>
Comment 4 WebKit Commit Bot 2013-07-02 17:19:24 PDT 
All reviewed patches have been landed.  Closing bug.