Bug 118316 - Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
Summary: Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 12:06 PDT by Mark Hahnenberg
Modified: 2013-07-02 12:48 PDT (History)
0 users

See Also:

Attachments
Patch (1.73 KB, patch)
2013-07-02 12:13 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2013-07-02 12:23 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-07-02 12:06:19 PDT 
This is causing some crashiness in release builds. We should replace it with an ASSERT until we track down all the places that need fixing in bug 118315.
Comment 1 Mark Hahnenberg 2013-07-02 12:10:11 PDT 
<rdar://problem/14165332>
Comment 2 Mark Hahnenberg 2013-07-02 12:13:43 PDT 
Created attachment 205935 [details]
Patch
Comment 3 Geoffrey Garen 2013-07-02 12:15:44 PDT 
Comment on attachment 205935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.h:228
> +        ASSERT(index < m_rareData->m_callReturnIndexVector.size());
> +        if (index < m_rareData->m_callReturnIndexVector.size())

I think you have this backwards?
Comment 4 Mark Hahnenberg 2013-07-02 12:21:40 PDT 
(In reply to comment #3)
> (From update of attachment 205935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.h:228
> > +        ASSERT(index < m_rareData->m_callReturnIndexVector.size());
> > +        if (index < m_rareData->m_callReturnIndexVector.size())
> 
> I think you have this backwards?

:-(
Comment 5 Mark Hahnenberg 2013-07-02 12:23:23 PDT 
Created attachment 205936 [details]
Patch
Comment 6 Geoffrey Garen 2013-07-02 12:30:56 PDT 
Comment on attachment 205936 [details]
Patch

r=me!
Comment 7 Mark Hahnenberg 2013-07-02 12:48:43 PDT 
Committed r152314: <http://trac.webkit.org/changeset/152314>