Bug 118312 - OpenGLShims doesn't have getProcAddress for Windows
Summary: OpenGLShims doesn't have getProcAddress for Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P4 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 11:36 PDT by Alex Christensen
Modified: 2013-07-02 22:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2013-07-02 11:38 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-02 11:36:37 PDT 
OpenGLShims.cpp has a getProcAddress function used for filling a function table with function pointers to OpenGL functions.  This function is implemented for Qt and it assumes everything else uses unix commands like dlsym.  I added a Windows implementation that uses the WinAPI to do the same thing.  I stepped through it in the debugger, and this succeeds in filling the function table with valid function pointers when linking with ANGLE libraries (of which libGLESv2 is one).
Comment 1 Alex Christensen 2013-07-02 11:38:15 PDT 
Created attachment 205931 [details]
Patch
Comment 2 Brent Fulgham 2013-07-02 14:22:54 PDT 
Comment on attachment 205931 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-07-02 15:19:21 PDT 
Comment on attachment 205931 [details]
Patch

Clearing flags on attachment: 205931

Committed r152325: <http://trac.webkit.org/changeset/152325>
Comment 4 WebKit Commit Bot 2013-07-02 15:19:23 PDT 
All reviewed patches have been landed.  Closing bug.