Bug 118302 – [Qt][WK1] Support direct painting without GraphicsSurface

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Allan Sandfeld Jensen]

In bug #118251 I reintroduced WebGL without graphics surfaces. It does however do inefficient pixel copies from one OpenGL context to the other. A few simple changes should allow us to do more effective texture copy.

[Allan Sandfeld Jensen]

Created attachment 205908 [details]
Patch

[Zeno Albisser]

Comment on attachment 205908 [details]
Patch

LGTM

[Jocelyn Turcotte]

Comment on attachment 205908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205908&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:257
> +#else

What happens if we're running WebKit2 in a !USE(GRAPHICS_SURFACE) build? Maybe we also need runtime detection for WK1/2.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:263
> +

Not needed.

[Allan Sandfeld Jensen]

(In reply to comment #3)
> (From update of attachment 205908 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205908&action=review
> 
> > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:257
> > +#else
> 
> What happens if we're running WebKit2 in a !USE(GRAPHICS_SURFACE) build? Maybe we also need runtime detection for WK1/2.
> 
There was a crash I have fixed, but we do not support canvas content in coordinated graphics without graphics-surfaces.

[Allan Sandfeld Jensen]

Created attachment 207244 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 205908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205908&action=review

>>> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:257
>>> +#else
>> 
>> What happens if we're running WebKit2 in a !USE(GRAPHICS_SURFACE) build? Maybe we also need runtime detection for WK1/2.
> 
> There was a crash I have fixed, but we do not support canvas content in coordinated graphics without graphics-surfaces.

Ok I was wrong, paintToTextureMapper will never be called for WK2 and "textureMapper->accelerationMode() == TextureMapper::OpenGLMode" will be enough to pick the right code path.

[Jocelyn Turcotte]

Comment on attachment 207244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207244&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:98
> +    bool m_canPaintDirectly;

r=me if you remove this member.

[Allan Sandfeld Jensen]

Committed r152969: <http://trac.webkit.org/changeset/152969>