Bug 118299 - Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
Summary: Modernize QualifiedName by wrapping gNameCache in a function and using more e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-02 05:54 PDT by Ryosuke Niwa
Modified: 2013-07-14 18:30 PDT (History)
7 users (show)

See Also:

Attachments
Cleanup (3.43 KB, patch)
2013-07-02 05:58 PDT, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-02 05:54:19 PDT 
It seems like QualifiedName.cpp hasn’t been updated in a while. Do some cleanups to match the modern coding style in WebKit.
Comment 1 Ryosuke Niwa 2013-07-02 05:58:12 PDT 
Created attachment 205898 [details]
Cleanup
Comment 2 Ryosuke Niwa 2013-07-02 22:08:52 PDT 
Landed as https://trac.webkit.org/r152337.
Comment 3 Benjamin Poulain 2013-07-02 23:20:32 PDT 
Comment on attachment 205898 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=205898&action=review

Man, you have a hard time vacationing :-D

> Source/WebCore/dom/QualifiedName.cpp:124
> +    result.append(prefix());
> +    result.append(':');
> +    result.append(localName());
> +    return result.toString();

return prefix() + ':' + localName(); would be better here.
Comment 4 Ryosuke Niwa 2013-07-14 17:45:08 PDT 
Committed r152618: <http://trac.webkit.org/changeset/152618>
Comment 5 Ryosuke Niwa 2013-07-14 18:30:26 PDT 
Fixed Qt builds:
http://trac.webkit.org/changeset/152621
http://trac.webkit.org/changeset/152622