RESOLVED WONTFIX 118293
[webkitpy] Add run-tests-touched-by-attachment command 
https://bugs.webkit.org/show_bug.cgi?id=118293
Summary [webkitpy] Add run-tests-touched-by-attachment command
Csaba Osztrogonác
Reported 2013-07-02 05:04:56 PDT
We need a new run-tests-touched-by-attachment command for webkit-patch. It should download the given attachment from bugzilla, apply the patch, build with the patch, determine which tests or expected files are touched by the attachment on any platform, run only these tests. It will be necessary for the rebaseline helper tools. See https://bugs.webkit.org/show_bug.cgi?id=117831 for details.
Attachments
WIP patch (6.21 KB, patch)
2013-07-02 06:47 PDT, János Badics 		ossy: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
János Badics
Comment 1 2013-07-02 06:47:15 PDT
Created attachment 205907 [details] WIP patch The tool can be run by 'Tools/Scripts/webkit-patch run-tests-touched-by-attachment [ATTACHMENT_ID]' At the current state, the tool gets the paths of modified expected txt/png files. Then it determines the filename without the '-expected' suffix and the file extension. _test_relative_dir() determines the relative generic directory path for the given test, e.g. LayoutTests/platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.txt -> editing/deleting/ Then _tests_in_dir gets the paths of all the tests found in this directory. As a last step, the loop in _first_generic_by_filename() gets the first match to the given file name. I know it's a bit ineffective, but we have to look up the extension for the given test file name, since a lot of extensions are supported for test files (htm, html, xhtml, etc.). Further modifications are also needed, especially the ones recommended by Ryosuke Niwa at https://bugs.webkit.org/show_bug.cgi?id=117831
Csaba Osztrogonác
Comment 2 2014-12-03 03:53:10 PST
no interest in it anymore
Note You need to log in before you can comment on or make changes to this bug.