Bug 118261 – Web Inspector: link to WebInspectorUI normal now that it is open source

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

We can stop soft linking WebInspectorUI.framework now that is is built in the open source tree. This fixes a sandbox violation in other apps too.

<rdar://problem/14205300>

[Timothy Hatcher]

Created attachment 205829 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 205829 [details]
Patch

r=me

[Build Bot]

Comment on attachment 205829 [details]
Patch

Attachment 205829 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/877904

[Timothy Hatcher]

Created attachment 205833 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 205833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205833&action=review

r=me

> Source/Makefile:1
> +MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebInspectorUI WebKit WebKit2

Good catch!

> Tools/Scripts/build-webkit:231
> -    push @projects, ("Source/WebInspectorUI");
> +    # WebInspectorUI must come before WebKit and WebKit2
> +    unshift @projects, ("Source/WebInspectorUI");

So, unshift puts this at the front. So now WebInspectorUI happens before anything (including ANGLE). It might be nice to do WebInspectorUI between WebCore and WebKit. I think that logically makes more sense. But it doesn't really matter.

[WebKit Commit Bot]

Comment on attachment 205833 [details]
Patch

Clearing flags on attachment: 205833

Committed r152267: <http://trac.webkit.org/changeset/152267>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.