Bug 118261 - Web Inspector: link to WebInspectorUI normal now that it is open source
Summary: Web Inspector: link to WebInspectorUI normal now that it is open source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-01 12:57 PDT by Timothy Hatcher
Modified: 2013-07-01 15:23 PDT (History)
8 users (show)

See Also:

Attachments
Patch (11.66 KB, patch)
2013-07-01 13:00 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (14.12 KB, patch)
2013-07-01 13:59 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-07-01 12:57:32 PDT 
We can stop soft linking WebInspectorUI.framework now that is is built in the open source tree. This fixes a sandbox violation in other apps too.

<rdar://problem/14205300>
Comment 1 Timothy Hatcher 2013-07-01 13:00:24 PDT 
Created attachment 205829 [details]
Patch
Comment 2 Joseph Pecoraro 2013-07-01 13:13:28 PDT 
Comment on attachment 205829 [details]
Patch

r=me
Comment 3 Build Bot 2013-07-01 13:24:28 PDT 
Comment on attachment 205829 [details]
Patch

Attachment 205829 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/877904
Comment 4 Timothy Hatcher 2013-07-01 13:59:59 PDT 
Created attachment 205833 [details]
Patch
Comment 5 Joseph Pecoraro 2013-07-01 15:02:15 PDT 
Comment on attachment 205833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205833&action=review

r=me

> Source/Makefile:1
> +MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebInspectorUI WebKit WebKit2

Good catch!

> Tools/Scripts/build-webkit:231
> -    push @projects, ("Source/WebInspectorUI");
> +    # WebInspectorUI must come before WebKit and WebKit2
> +    unshift @projects, ("Source/WebInspectorUI");

So, unshift puts this at the front. So now WebInspectorUI happens before anything (including ANGLE). It might be nice to do WebInspectorUI between WebCore and WebKit. I think that logically makes more sense. But it doesn't really matter.
Comment 6 WebKit Commit Bot 2013-07-01 15:23:50 PDT 
Comment on attachment 205833 [details]
Patch

Clearing flags on attachment: 205833

Committed r152267: <http://trac.webkit.org/changeset/152267>
Comment 7 WebKit Commit Bot 2013-07-01 15:23:52 PDT 
All reviewed patches have been landed.  Closing bug.