Bug 118259 - AX: Items the img aria role aren't inserting an object replacement character
Summary: AX: Items the img aria role aren't inserting an object replacement character
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 11:47 PDT by chris fleizach
Modified: 2013-07-03 22:29 PDT (History)
0 users

See Also:


Attachments
patch (7.80 KB, patch)
2013-07-01 14:22 PDT, chris fleizach
thorton: review+
Details | Formatted Diff | Diff
patch for landing (7.56 KB, patch)
2013-07-03 17:53 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-07-01 11:47:00 PDT
The object replacement character is not being emitted when encountering an element with <div role="img">
However, native images do get an emission
Comment 1 chris fleizach 2013-07-01 14:22:06 PDT
Created attachment 205835 [details]
patch
Comment 2 Tim Horton 2013-07-01 23:33:51 PDT
Comment on attachment 205835 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205835&action=review

patch doesn't apply.

> Source/WebCore/ChangeLog:3
> +        AX: Items the img aria role aren't inserting an object replacement character

This title is missing some words (or has some extras?).

> LayoutTests/platform/mac/accessibility/aria-image-emits-object-replacement.html~:1
> +<!DOCTYPE HTML>

please don't commit this extraneous html~ file :D
Comment 3 chris fleizach 2013-07-03 17:53:06 PDT
Created attachment 206039 [details]
patch for landing
Comment 4 chris fleizach 2013-07-03 22:29:09 PDT
http://trac.webkit.org/changeset/152388