Bug 118244 - [Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
Summary: [Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 07:02 PDT by Allan Sandfeld Jensen
Modified: 2013-07-01 07:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.49 KB, patch)
2013-07-01 07:05 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-07-01 07:02:11 PDT
With Qt 5.0 we had to create a QWindow inorder to make a QOpenGLContext current. In Qt 5.1 we have the option of using a QOffscreenSurface instead. On platforms like X11 the results will be the same, but on OpenGL based platforms the QOffscreenSurface will use a pbuffer.
Comment 1 Allan Sandfeld Jensen 2013-07-01 07:05:20 PDT
Created attachment 205809 [details]
Patch
Comment 2 Noam Rosenthal 2013-07-01 07:17:06 PDT
Comment on attachment 205809 [details]
Patch

Nice!
Comment 3 Allan Sandfeld Jensen 2013-07-01 07:30:03 PDT
Comment on attachment 205809 [details]
Patch

Clearing flags on attachment: 205809

Committed r152222: <http://trac.webkit.org/changeset/152222>
Comment 4 Allan Sandfeld Jensen 2013-07-01 07:30:08 PDT
All reviewed patches have been landed.  Closing bug.