Bug 118230 – [GTK] Use PassOwnPtr for the returned value of createBackingStore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

I think it would be better that createBackingStore returns  PassOwnPtr instread of OwnPtr to keep compatibility with c++0x.
Otherwise we face following break with the c++0x compile option.

[shivamidow@LenovoStation:Release]$ make -j 3
make  all-am
make[1]: Entering directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
/bin/mkdir -p ./.deps/DerivedSources
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-ChromeClientGtk.lo
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-FrameLoaderClientGtk.lo
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-FrameNetworkingContextGtk.lo
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-GeolocationClientGtk.lo
In file included from ../../Source/WTF/wtf/VectorTraits.h:25:0,
                 from ../../Source/WTF/wtf/Vector.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatRect.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatQuad.h:33,
                 from ../../Source/WebCore/accessibility/AccessibilityObject.h:33,
                 from ../../Source/WebCore/accessibility/AXObjectCache.h:29,
                 from ../../Source/WebCore/page/ChromeClient.h:25,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:24,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:26:
../../Source/WTF/wtf/OwnPtr.h: In member function 'virtual void WebKit::ChromeClient::attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*)':
../../Source/WTF/wtf/OwnPtr.h:97:17: error: 'WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::WidgetBackingStore; WTF::OwnPtr<T> = WTF::OwnPtr<WebCore::WidgetBackingStore>]' is private
../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:1072:96: error: within this context
In file included from ../../Source/WTF/wtf/VectorTraits.h:25:0,
                 from ../../Source/WTF/wtf/Vector.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatRect.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatQuad.h:33,
                 from ../../Source/WebCore/accessibility/AccessibilityObject.h:33,
                 from ../../Source/WebCore/accessibility/AXObjectCache.h:29,
                 from ../../Source/WebCore/page/ChromeClient.h:25,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:24,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:26:
../../Source/WTF/wtf/OwnPtr.h:97:17: error: 'WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::WidgetBackingStore; WTF::OwnPtr<T> = WTF::OwnPtr<WebCore::WidgetBackingStore>]' is private
../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:1076:115: error: within this context
make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-ChromeClientGtk.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
make: *** [all] Error 2

[ChangSeok Oh]

Created attachment 205786 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 205786 [details]
Patch

Clearing flags on attachment: 205786

Committed r152216: <http://trac.webkit.org/changeset/152216>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.