Bug 118230 - [GTK] Use PassOwnPtr for the returned value of createBackingStore
Summary: [GTK] Use PassOwnPtr for the returned value of createBackingStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-30 23:54 PDT by ChangSeok Oh
Modified: 2013-07-01 01:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2013-06-30 23:59 PDT, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-06-30 23:54:25 PDT 
I think it would be better that createBackingStore returns  PassOwnPtr instread of OwnPtr to keep compatibility with c++0x.
Otherwise we face following break with the c++0x compile option.

[shivamidow@LenovoStation:Release]$ make -j 3
make  all-am
make[1]: Entering directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
/bin/mkdir -p ./.deps/DerivedSources
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-ChromeClientGtk.lo
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-FrameLoaderClientGtk.lo
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-FrameNetworkingContextGtk.lo
  CXX    Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-GeolocationClientGtk.lo
In file included from ../../Source/WTF/wtf/VectorTraits.h:25:0,
                 from ../../Source/WTF/wtf/Vector.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatRect.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatQuad.h:33,
                 from ../../Source/WebCore/accessibility/AccessibilityObject.h:33,
                 from ../../Source/WebCore/accessibility/AXObjectCache.h:29,
                 from ../../Source/WebCore/page/ChromeClient.h:25,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:24,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:26:
../../Source/WTF/wtf/OwnPtr.h: In member function 'virtual void WebKit::ChromeClient::attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*)':
../../Source/WTF/wtf/OwnPtr.h:97:17: error: 'WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::WidgetBackingStore; WTF::OwnPtr<T> = WTF::OwnPtr<WebCore::WidgetBackingStore>]' is private
../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:1072:96: error: within this context
In file included from ../../Source/WTF/wtf/VectorTraits.h:25:0,
                 from ../../Source/WTF/wtf/Vector.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatRect.h:31,
                 from ../../Source/WebCore/platform/graphics/FloatQuad.h:33,
                 from ../../Source/WebCore/accessibility/AccessibilityObject.h:33,
                 from ../../Source/WebCore/accessibility/AXObjectCache.h:29,
                 from ../../Source/WebCore/page/ChromeClient.h:25,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:24,
                 from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:26:
../../Source/WTF/wtf/OwnPtr.h:97:17: error: 'WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::WidgetBackingStore; WTF::OwnPtr<T> = WTF::OwnPtr<WebCore::WidgetBackingStore>]' is private
../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:1076:115: error: within this context
make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-ChromeClientGtk.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
make: *** [all] Error 2
Comment 1 ChangSeok Oh 2013-06-30 23:59:35 PDT 
Created attachment 205786 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-01 01:44:47 PDT 
Comment on attachment 205786 [details]
Patch

Clearing flags on attachment: 205786

Committed r152216: <http://trac.webkit.org/changeset/152216>
Comment 3 WebKit Commit Bot 2013-07-01 01:44:49 PDT 
All reviewed patches have been landed.  Closing bug.