Bug 118218 - Avoid calling isSimpleContainerCompositingLayer() an extra time
Summary: Avoid calling isSimpleContainerCompositingLayer() an extra time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-29 12:47 PDT by Simon Fraser (smfr)
Modified: 2013-06-29 13:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2013-06-29 12:48 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-06-29 12:47:48 PDT 
Avoid calling isSimpleContainerCompositingLayer() an extra time
Comment 1 Simon Fraser (smfr) 2013-06-29 12:48:59 PDT 
Created attachment 205772 [details]
Patch
Comment 2 Tim Horton 2013-06-29 12:56:14 PDT 
Comment on attachment 205772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205772&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:982
> +    bool hasPaintedContent = containsPaintedContent(isSimpleContainer);

Wait, do you even need to pass it in? In the previous case, you were not calling in ever if it was false, so you can assume it's true? And, before, you were avoiding the function call at all...
Comment 3 Simon Fraser (smfr) 2013-06-29 13:23:22 PDT 
https://trac.webkit.org/r152213