RESOLVED FIXED 118216
Avoid calling into Objective-C every time we get the scrollbar width 
https://bugs.webkit.org/show_bug.cgi?id=118216
Summary Avoid calling into Objective-C every time we get the scrollbar width
Simon Fraser (smfr)
Reported 2013-06-29 11:51:24 PDT
Avoid calling into Objective-C every time we get the scrollbar width
Attachments
Patch (4.93 KB, patch)
2013-06-29 11:54 PDT, Simon Fraser (smfr) 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-06-29 11:54:20 PDT
Created attachment 205771 [details] Patch
Geoffrey Garen
Comment 2 2013-06-29 12:18:53 PDT
Comment on attachment 205771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205771&action=review r=me > Source/WebCore/ChangeLog:12 > + is one that gets called when the user changes the setting in System Preferences. "is the function" maybe? > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:136 > +static bool gUseOverlayScrollbars = false; Can we call this gUsesOverlayScrollbars, to match the function name? (I added an 's'.)
Simon Fraser (smfr)
Comment 3 2013-06-29 13:28:06 PDT
https://trac.webkit.org/r152214
Darin Adler
Comment 4 2013-07-01 11:57:31 PDT
Comment on attachment 205771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205771&action=review > Source/WebCore/platform/ScrollbarTheme.h:60 > + virtual void usesOverlayScrollbarsChanged() { } This should not have been added. Nobody needs to call this as a virtual function. > Source/WebCore/platform/mac/ScrollbarThemeMac.h:50 > + virtual void usesOverlayScrollbarsChanged() OVERRIDE; This should be a non-virtual function.
Note You need to log in before you can comment on or make changes to this bug.