Bug 118214 – Build fix for unguarded SVGGraphicsElement

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[ChangSeok Oh]

I faced following break when disabling svg features.

[shivamidow@LenovoStation:Release]$ make -j 4
make[1]: Entering directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
/bin/mkdir -p ./.deps/DerivedSources
  CXXLD  libwebkit2gtkinjectedbundle.la
  CXXLD  libjavascriptcoregtk-3.0.la
  CXXLD  libPlatform.la
  CXXLD  libPlatformGtk.la
  CXX    DerivedSources/WebCore/libWebCore_la-JSDOMWindow.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSEventTarget.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFile.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileCallback.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileEntry.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileEntrySync.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileError.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileException.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileList.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileReader.lo
In file included from DerivedSources/WebCore/JSDOMWindow.cpp:216:0:
DerivedSources/WebCore/JSSVGGraphicsElement.h:32:56: error: expected class-name before '{' token
DerivedSources/WebCore/JSSVGGraphicsElement.h:34:13: error: 'JSSVGStyledElement' does not name a type
DerivedSources/WebCore/JSSVGGraphicsElement.h:35:112: error: 'SVGGraphicsElement' was not declared in this scope
In file included from DerivedSources/WebCore/JSDOMWindow.cpp:216:0:
DerivedSources/WebCore/JSSVGGraphicsElement.h:35:130: error: template argument 1 is invalid
DerivedSources/WebCore/JSSVGGraphicsElement.h:54:74: error: 'SVGGraphicsElement' was not declared in this scope
DerivedSources/WebCore/JSSVGGraphicsElement.h:54:92: error: template argument 1 is invalid
DerivedSources/WebCore/JSSVGGraphicsElement.h:56:145: error: 'Base' has not been declared
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileReaderSync.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileSystemCallback.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileWriter.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileWriterCallback.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFileWriterSync.lo
In file included from ../../Source/JavaScriptCore/runtime/JSCJSValueInlines.h:31:0,
                 from ../../Source/JavaScriptCore/runtime/Operations.h:27,
                 from ../../Source/WebCore/bindings/js/BindingState.h:35,
                 from ../../Source/WebCore/bindings/js/JSDOMBinding.h:27,
                 from DerivedSources/WebCore/JSDOMWindow.h:25,
                 from DerivedSources/WebCore/JSDOMWindow.cpp:22:
../../Source/JavaScriptCore/runtime/JSCellInlines.h: In instantiation of 'void* JSC::allocateCell(JSC::Heap&, size_t) [with T = WebCore::JSSVGGraphicsElement; JSC::Heap = JSC::Heap; size_t = long unsigned int]':
../../Source/JavaScriptCore/runtime/JSCellInlines.h:104:43:   required from 'void* JSC::allocateCell(JSC::Heap&) [with T = WebCore::JSSVGGraphicsElement; JSC::Heap = JSC::Heap]'
DerivedSources/WebCore/JSSVGGraphicsElement.h:37:114:   required from here
../../Source/JavaScriptCore/runtime/JSCellInlines.h:91:5: error: 'hasImmortalStructure' is not a member of 'WebCore::JSSVGGraphicsElement'
../../Source/JavaScriptCore/runtime/JSCellInlines.h:91:5: error: 'needsDestruction' is not a member of 'WebCore::JSSVGGraphicsElement'
../../Source/JavaScriptCore/runtime/JSCellInlines.h:93:10: error: 'needsDestruction' is not a member of 'WebCore::JSSVGGraphicsElement'
  CXX    DerivedSources/WebCore/libWebCore_la-JSFloat32Array.lo
  CXX    DerivedSources/WebCore/libWebCore_la-JSFloat64Array.lo
make[1]: *** [DerivedSources/WebCore/libWebCore_la-JSDOMWindow.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
make: *** [all] Error 2

[ChangSeok Oh]

Created attachment 205767 [details]
Patch

[Chris Dumez]

Comment on attachment 205767 [details]
Patch

Looks good, thanks. r=me.

[WebKit Commit Bot]

Comment on attachment 205767 [details]
Patch

Clearing flags on attachment: 205767

Committed r152210: <http://trac.webkit.org/changeset/152210>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.