Bug 118212 – Adopt is/toHTMLOptionElement for code cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kangil Han]

Adopt is/toHTMLOptionElement for code cleanup

[Kangil Han]

Created attachment 205763 [details]
Patch

[Andreas Kling]

Comment on attachment 205763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205763&action=review

r=me

> Source/WebCore/html/HTMLCollection.cpp:227
>          if (element->hasLocalName(optionTag)) {

I wonder if we could use isHTMLOptionElement() here instead of just checking the localName.

> Source/WebCore/html/HTMLSelectElement.cpp:244
> +        if (items[i]->hasLocalName(optionTag)) {

Ditto.

> Source/WebCore/html/HTMLSelectElement.cpp:265
>          if (items[i]->hasLocalName(optionTag)) {

Ditto.

> Source/WebCore/html/HTMLSelectElement.cpp:979
>          if (!items[i]->hasLocalName(optionTag))

Ditto.

[Kangil Han]

(In reply to comment #2)
> (From update of attachment 205763 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205763&action=review
> 
> r=me
> 
> > Source/WebCore/html/HTMLCollection.cpp:227
> >          if (element->hasLocalName(optionTag)) {
> 
> I wonder if we could use isHTMLOptionElement() here instead of just checking the localName.
> 
> > Source/WebCore/html/HTMLSelectElement.cpp:244
> > +        if (items[i]->hasLocalName(optionTag)) {
> 
> Ditto.
> 
> > Source/WebCore/html/HTMLSelectElement.cpp:265
> >          if (items[i]->hasLocalName(optionTag)) {
> 
> Ditto.
> 
> > Source/WebCore/html/HTMLSelectElement.cpp:979
> >          if (!items[i]->hasLocalName(optionTag))
> 
> Ditto.

Agreed.
IMHO, I can replace hasLocalName(tag) stuff with isFooElement in another patch when adoption is/toFooElement is completed. :)

[WebKit Commit Bot]

Comment on attachment 205763 [details]
Patch

Clearing flags on attachment: 205763

Committed r152208: <http://trac.webkit.org/changeset/152208>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.