Bug 118210 - PageThrottler::shouldThrottleTimers is wrong.
Summary: PageThrottler::shouldThrottleTimers is wrong.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 18:20 PDT by Gavin Barraclough
Modified: 2013-06-28 22:56 PDT (History)
5 users (show)

See Also:

Attachments
Fix (1.58 KB, patch)
2013-06-28 18:31 PDT, Gavin Barraclough 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-06-28 18:20:53 PDT 
m_throttleState == PageNotThrottledState
    -> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
    -> page NOT NOT throttled, so should throttle timers

This needs cleaning up, but for now, 1 character fix.
Comment 1 Gavin Barraclough 2013-06-28 18:31:59 PDT 
Created attachment 205760 [details]
Fix

Fixes <rdar://problem/14247819>
Comment 2 Gavin Barraclough 2013-06-28 18:45:50 PDT 
Committed revision 152202.
Comment 3 Andreas Kling 2013-06-28 22:56:04 PDT 
This change broke fast/dom/timer-throttling-hidden-page.html on Mac:

http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r152202%20(11080)/results.html