Bug 118208 - [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
Summary: [Mac] Newer versions of clang use a default template instantiation depth that...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 16:12 PDT by Andy Estes
Modified: 2013-06-28 16:40 PDT (History)
0 users

See Also:

Attachments
Patch (1.72 KB, patch)
2013-06-28 16:17 PDT, Andy Estes 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-06-28 16:12:12 PDT 
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
Comment 1 Andy Estes 2013-06-28 16:17:22 PDT 
Created attachment 205752 [details]
Patch
Comment 2 Tim Horton 2013-06-28 16:18:57 PDT 
Comment on attachment 205752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205752&action=review

> Tools/ChangeLog:8
> +        Newer versions of clang use a default template depth to 128, but this

s/to/of/?
Comment 3 Mark Rowe (bdash) 2013-06-28 16:24:08 PDT 
Comment on attachment 205752 [details]
Patch

What Tim said. It may be worth briefly summarizing why it's ok for us to bump the depth back up when clang has changed it downwards, or even just putting a reference in to the radar you mentioned to me. Something to give us a reference point if we eventually wonder why we added this flag.
Comment 4 Andy Estes 2013-06-28 16:40:52 PDT 
Committed r152195: <http://trac.webkit.org/changeset/152195>