Bug 118198 - media/video-currentTime.html flakey
Summary: media/video-currentTime.html flakey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-28 11:34 PDT by Jer Noble
Modified: 2013-07-02 09:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2013-06-28 11:37 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-06-28 11:34:57 PDT 
media/video-currentTime.html flakey
Comment 1 Jer Noble 2013-06-28 11:37:01 PDT 
Created attachment 205729 [details]
Patch
Comment 2 Eric Carlson 2013-06-28 12:20:14 PDT 
Comment on attachment 205729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205729&action=review

> LayoutTests/media/video-currentTime-expected.txt:5
> +video.currentTime > 0 OK

Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ?
Comment 3 Jer Noble 2013-06-28 12:29:25 PDT 
Comment on attachment 205729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205729&action=review

>> LayoutTests/media/video-currentTime-expected.txt:5
>> +video.currentTime > 0 OK
> 
> Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ?

Yes, because the first timeupdate event will likely always be at currentTime == 0.
Comment 4 WebKit Commit Bot 2013-06-28 12:55:51 PDT 
Comment on attachment 205729 [details]
Patch

Clearing flags on attachment: 205729

Committed r152184: <http://trac.webkit.org/changeset/152184>
Comment 5 WebKit Commit Bot 2013-06-28 12:55:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2013-07-02 09:37:40 PDT 
<rdar://problem/14333042>