WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118198
media/video-currentTime.html flakey
https://bugs.webkit.org/show_bug.cgi?id=118198
Summary
media/video-currentTime.html flakey
Jer Noble
Reported
2013-06-28 11:34:57 PDT
media/video-currentTime.html flakey
Attachments
Patch
(2.40 KB, patch)
2013-06-28 11:37 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2013-06-28 11:37:01 PDT
Created
attachment 205729
[details]
Patch
Eric Carlson
Comment 2
2013-06-28 12:20:14 PDT
Comment on
attachment 205729
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=205729&action=review
> LayoutTests/media/video-currentTime-expected.txt:5 > +video.currentTime > 0 OK
Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ?
Jer Noble
Comment 3
2013-06-28 12:29:25 PDT
Comment on
attachment 205729
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=205729&action=review
>> LayoutTests/media/video-currentTime-expected.txt:5 >> +video.currentTime > 0 OK > > Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ?
Yes, because the first timeupdate event will likely always be at currentTime == 0.
WebKit Commit Bot
Comment 4
2013-06-28 12:55:51 PDT
Comment on
attachment 205729
[details]
Patch Clearing flags on attachment: 205729 Committed
r152184
: <
http://trac.webkit.org/changeset/152184
>
WebKit Commit Bot
Comment 5
2013-06-28 12:55:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2013-07-02 09:37:40 PDT
<
rdar://problem/14333042
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug