Bug 118192 – Update TestExpectations so new Shapes tests are skipped where the old ones were

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Bem Jones-Bey]

Update TestExpectations so new Shapes tests are skipped where the old ones were

[Bem Jones-Bey]

Created attachment 205714 [details]
Patch

Update expectations so that the new tests are skipped on platforms the old tests were skipped on.

[Chris Dumez]

Comment on attachment 205714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review

> LayoutTests/platform/efl/TestExpectations:341
> +webkit.org/b/83898 csswg/submitted/shapes

Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine.

[Bem Jones-Bey]

(In reply to comment #2)
> (From update of attachment 205714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review
> 
> > LayoutTests/platform/efl/TestExpectations:341
> > +webkit.org/b/83898 csswg/submitted/shapes
> 
> Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine.

That's great news. I'll remove the expectations for EFL completely and upload a new patch.

[Bem Jones-Bey]

Created attachment 205716 [details]
Patch

Remove shapes skipping for EFL since it is apparently enabled now.

[Chris Dumez]

Comment on attachment 205716 [details]
Patch

I cannot speak for the windows part but the EFL changes look good to me.

[Brent Fulgham]

Comment on attachment 205716 [details]
Patch

r=me.

[WebKit Commit Bot]

Comment on attachment 205716 [details]
Patch

Clearing flags on attachment: 205716

Committed r152180: <http://trac.webkit.org/changeset/152180>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.