Bug 118192 - Update TestExpectations so new Shapes tests are skipped where the old ones were
Summary: Update TestExpectations so new Shapes tests are skipped where the old ones were
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 07:54 PDT by Bem Jones-Bey
Modified: 2013-06-28 11:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2013-06-28 07:55 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch (2.83 KB, patch)
2013-06-28 08:20 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-06-28 07:54:27 PDT 
Update TestExpectations so new Shapes tests are skipped where the old ones were
Comment 1 Bem Jones-Bey 2013-06-28 07:55:09 PDT 
Created attachment 205714 [details]
Patch

Update expectations so that the new tests are skipped on platforms the old tests were skipped on.
Comment 2 Chris Dumez 2013-06-28 08:08:36 PDT 
Comment on attachment 205714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review

> LayoutTests/platform/efl/TestExpectations:341
> +webkit.org/b/83898 csswg/submitted/shapes

Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine.
Comment 3 Bem Jones-Bey 2013-06-28 08:18:13 PDT 
(In reply to comment #2)
> (From update of attachment 205714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review
> 
> > LayoutTests/platform/efl/TestExpectations:341
> > +webkit.org/b/83898 csswg/submitted/shapes
> 
> Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine.

That's great news. I'll remove the expectations for EFL completely and upload a new patch.
Comment 4 Bem Jones-Bey 2013-06-28 08:20:43 PDT 
Created attachment 205716 [details]
Patch

Remove shapes skipping for EFL since it is apparently enabled now.
Comment 5 Chris Dumez 2013-06-28 08:40:13 PDT 
Comment on attachment 205716 [details]
Patch

I cannot speak for the windows part but the EFL changes look good to me.
Comment 6 Brent Fulgham 2013-06-28 11:01:50 PDT 
Comment on attachment 205716 [details]
Patch

r=me.
Comment 7 WebKit Commit Bot 2013-06-28 11:09:00 PDT 
Comment on attachment 205716 [details]
Patch

Clearing flags on attachment: 205716

Committed r152180: <http://trac.webkit.org/changeset/152180>
Comment 8 WebKit Commit Bot 2013-06-28 11:09:04 PDT 
All reviewed patches have been landed.  Closing bug.