Bug 118187 - accessibility/media-element.html does not support platforms without subroles
Summary: accessibility/media-element.html does not support platforms without subroles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 05:43 PDT by Mario Sanchez Prada
Modified: 2013-06-28 09:40 PDT (History)
12 users (show)

See Also:

Attachments
Patch proposal (2.15 KB, patch)
2013-06-28 05:50 PDT, Mario Sanchez Prada 		cfleizach: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (675.23 KB, application/zip)
2013-06-28 08:35 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2013-06-28 05:43:55 PDT 
In revision r151852, the accessibility/media-element-pretty-diff.html test was expanded to also print subroles whenever available, but is always assuming that at least the "AXSubrole: " string will be returned when reading the .subrole property, which does not apply to platforms not supporting subroles, like ATK.
Comment 1 Mario Sanchez Prada 2013-06-28 05:50:43 PDT 
Created attachment 205706 [details]
Patch proposal

I believe this extra nullcheck would be enough to make the GTK bots happy again, without disturbing others
Comment 2 Build Bot 2013-06-28 08:35:30 PDT 
Comment on attachment 205706 [details]
Patch proposal

Attachment 205706 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/976517

New failing tests:
editing/pasteboard/5601583-1.html
Comment 3 Build Bot 2013-06-28 08:35:31 PDT 
Created attachment 205717 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 4 Mario Sanchez Prada 2013-06-28 09:40:12 PDT 
Committed r152172: <http://trac.webkit.org/changeset/152172>