RESOLVED FIXED 118186
[Autotools] Properly quote harfbuzz-icu pkg-config check 
https://bugs.webkit.org/show_bug.cgi?id=118186
Summary [Autotools] Properly quote harfbuzz-icu pkg-config check
Sean Bright
Reported 2013-06-28 05:12:48 PDT
A secondary test was added to check for harfbuzz-icu when it was split but the test wasn't properly quoted. If the test fails you get an error about missing version "./configure.9.8" instead of the expected "0.9.8".
Attachments
Patch (734 bytes, patch)
2013-06-28 05:23 PDT, Sean Bright 		no flags
DetailsFormatted DiffDiff
Patch (1.25 KB, patch)
2013-06-28 05:36 PDT, Sean Bright 		no flags
DetailsFormatted DiffDiff
Patch (1.53 KB, patch)
2013-06-28 05:46 PDT, Sean Bright 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sean Bright
Comment 1 2013-06-28 05:23:09 PDT
Created attachment 205701 [details] Patch
Zan Dobersek
Comment 2 2013-06-28 05:29:26 PDT
The patch looks OK, but requires a ChangeLog entry. The contributing documentation has some guidelines on how to prepare the ChangeLog. http://www.webkit.org/coding/contributing.html
Sean Bright
Comment 3 2013-06-28 05:36:58 PDT
Created attachment 205703 [details] Patch
Sean Bright
Comment 4 2013-06-28 05:39:06 PDT
(In reply to comment #2) > The patch looks OK, but requires a ChangeLog entry. Yes I had some issues with webkit-patch, so I manually created a diff with a ChangeLog entry and uploaded directly.
Carlos Garcia Campos
Comment 5 2013-06-28 05:41:11 PDT
Thanks for adding the changelog entry, but could you explain in the changelog what's the problem you are fixing? something similar to the first comment in this bug.
Sean Bright
Comment 6 2013-06-28 05:46:15 PDT
Created attachment 205705 [details] Patch
Sean Bright
Comment 7 2013-06-28 05:47:38 PDT
(In reply to comment #5) > but could you explain in the changelog what's the problem you are fixing? I've included more detail in the most recent attachment.
Carlos Garcia Campos
Comment 8 2013-06-28 05:52:51 PDT
Comment on attachment 205705 [details] Patch Thanks! It seems there are more cases like this one in FindDependencies.m4 we should fix them also eventually.
WebKit Commit Bot
Comment 9 2013-06-28 06:32:24 PDT
Comment on attachment 205705 [details] Patch Clearing flags on attachment: 205705 Committed r152163: <http://trac.webkit.org/changeset/152163>
WebKit Commit Bot
Comment 10 2013-06-28 06:32:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.