Bug 118177 - Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
Summary: Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 02:38 PDT by Iago Toral
Modified: 2013-06-28 04:00 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.33 KB, patch)
2013-06-28 02:41 PDT, Iago Toral 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iago Toral 2013-06-28 02:38:11 PDT 
Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp uses deprecated function gtk_widget_get_requisition, which produces compilation warnings. I'll attach a patch shortly to use gtk_widget_get_preferred_size instead, which is the function used to implement gtk_widget_get_requisition in GTK.
Comment 1 Iago Toral 2013-06-28 02:41:51 PDT 
Created attachment 205683 [details]
Proposed patch
Comment 2 Carlos Garcia Campos 2013-06-28 02:52:15 PDT 
Comment on attachment 205683 [details]
Proposed patch

Thanks!
Comment 3 WebKit Commit Bot 2013-06-28 04:00:15 PDT 
Comment on attachment 205683 [details]
Proposed patch

Clearing flags on attachment: 205683

Committed r152159: <http://trac.webkit.org/changeset/152159>
Comment 4 WebKit Commit Bot 2013-06-28 04:00:17 PDT 
All reviewed patches have been landed.  Closing bug.