Bug 118173 - [wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
Summary: [wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-28 02:17 PDT by Tim Horton
Modified: 2013-07-01 14:48 PDT (History)
3 users (show)

See Also:


Attachments
preliminary (5.04 KB, patch)
2013-06-28 03:11 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
patch (7.27 KB, patch)
2013-06-28 16:30 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-06-28 02:17:32 PDT
Currently we mandate that scrolling must be disabled if we're clipping to the WKView's visible/prepared-content rect, because TCADA doesn't know how to keep the exposed rect offset by the scroll position as it should. But, it can!
Comment 1 Radar WebKit Bug Importer 2013-06-28 02:18:02 PDT
<rdar://problem/14301166>
Comment 2 Tim Horton 2013-06-28 03:11:51 PDT
Created attachment 205688 [details]
preliminary
Comment 3 Tim Horton 2013-06-28 16:30:19 PDT
Created attachment 205755 [details]
patch
Comment 4 Sam Weinig 2013-06-28 16:47:23 PDT
Comment on attachment 205755 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205755&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:441
> +    for (PageOverlayLayerMap::iterator it = m_pageOverlayLayers.begin(), end = m_pageOverlayLayers.end(); it != end; ++it)
> +        if (TiledBacking* tiledBacking = it->value->tiledBacking())
> +            tiledBacking->setExposedRect(m_scrolledExposedRect);

Braces please.
Comment 5 Tim Horton 2013-06-28 16:57:52 PDT
Comment on attachment 205755 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205755&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:441
>> +            tiledBacking->setExposedRect(m_scrolledExposedRect);
> 
> Braces please.

Indeed.
Comment 6 Tim Horton 2013-07-01 14:48:43 PDT
http://trac.webkit.org/changeset/152266