Bug 118169 - REGRESSION(151586): multipart/x-mixed-replace images are broken
Summary: REGRESSION(151586): multipart/x-mixed-replace images are broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://158.250.33.102/view/view.htm
Keywords: InRadar
Depends on:
Blocks: 115804
  Show dependency treegraph
 
Reported: 2013-06-27 22:11 PDT by Alexey Proskuryakov
Modified: 2013-06-29 00:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2013-06-28 03:17 PDT, Carlos Garcia Campos
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-06-27 22:11:42 PDT
<http://trac.webkit.org/changeset/151586> broke a lot of webcam sites, such as <http://158.250.33.102/view/view.htm>.

<rdar://problem/14242032>
Comment 1 Carlos Garcia Campos 2013-06-28 01:04:36 PDT
It works for me, what's exactly broken?
Comment 2 Tim Horton 2013-06-28 01:45:48 PDT
I get corrupt and/or partial images in Safari.
Comment 3 Carlos Garcia Campos 2013-06-28 02:53:35 PDT
Actually it crashes for me in another laptop I've tried, I'm looking at it.
Comment 4 Tim Horton 2013-06-28 02:54:09 PDT
(In reply to comment #3)
> Actually it crashes for me in another laptop I've tried, I'm looking at it.

Yeah, I think we see that in some places too.
Comment 5 Carlos Garcia Campos 2013-06-28 03:17:38 PDT
Created attachment 205689 [details]
Patch

In case of multipart content we always have to copy the data, I removed that by mistake in r151586.
Comment 6 Chris Dumez 2013-06-28 03:56:10 PDT
Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash.
Backtrace: http://pastebin.com/xLcPkHHg
Comment 7 Carlos Garcia Campos 2013-06-28 04:21:24 PDT
(In reply to comment #6)
> Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash.
> Backtrace: http://pastebin.com/xLcPkHHg

Thanks for testing it, yes, same crash I got, the attached patch fixes the crash.
Comment 8 Alexey Proskuryakov 2013-06-28 09:44:35 PDT
Comment on attachment 205689 [details]
Patch

r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug.
Comment 9 Carlos Garcia Campos 2013-06-29 00:24:36 PDT
(In reply to comment #8)
> (From update of attachment 205689 [details])
> r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug.

Yes, I thought about it, but I didn't have time to understand how multipart layout tests work and how to write a new one (not that this was not easy to reproduce and had different effects to different people), so I submitted the patch without a test because it fixes a crash. I'll try to make a test next week.
Comment 10 Carlos Garcia Campos 2013-06-29 00:26:26 PDT
Committed r152207: <http://trac.webkit.org/changeset/152207>