Bug 118169 – REGRESSION(151586): multipart/x-mixed-replace images are broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Alexey Proskuryakov]

<http://trac.webkit.org/changeset/151586> broke a lot of webcam sites, such as <http://158.250.33.102/view/view.htm>.

<rdar://problem/14242032>

[Carlos Garcia Campos]

It works for me, what's exactly broken?

[Tim Horton]

I get corrupt and/or partial images in Safari.

[Carlos Garcia Campos]

Actually it crashes for me in another laptop I've tried, I'm looking at it.

[Tim Horton]

(In reply to comment #3)
> Actually it crashes for me in another laptop I've tried, I'm looking at it.

Yeah, I think we see that in some places too.

[Carlos Garcia Campos]

Created attachment 205689 [details]
Patch

In case of multipart content we always have to copy the data, I removed that by mistake in r151586.

[Chris Dumez]

Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash.
Backtrace: http://pastebin.com/xLcPkHHg

[Carlos Garcia Campos]

(In reply to comment #6)
> Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash.
> Backtrace: http://pastebin.com/xLcPkHHg

Thanks for testing it, yes, same crash I got, the attached patch fixes the crash.

[Alexey Proskuryakov]

Comment on attachment 205689 [details]
Patch

r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug.

[Carlos Garcia Campos]

(In reply to comment #8)
> (From update of attachment 205689 [details])
> r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug.

Yes, I thought about it, but I didn't have time to understand how multipart layout tests work and how to write a new one (not that this was not easy to reproduce and had different effects to different people), so I submitted the patch without a test because it fixes a crash. I'll try to make a test next week.

[Carlos Garcia Campos]

Committed r152207: <http://trac.webkit.org/changeset/152207>