RESOLVED FIXED 118168
Avoid duplicating hostWindow() call in ScrollView.cpp 
https://bugs.webkit.org/show_bug.cgi?id=118168
Summary Avoid duplicating hostWindow() call in ScrollView.cpp
Sanghyup Lee
Reported 2013-06-27 22:06:46 PDT
Patch follows.
Attachments
Patch (5.79 KB, patch)
2013-06-27 22:14 PDT, Sanghyup Lee 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2013-06-27 22:56 PDT, Sanghyup Lee 		no flags
DetailsFormatted DiffDiff
Patch (6.83 KB, patch)
2013-06-28 00:43 PDT, Sanghyup Lee 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.85 KB, patch)
2013-06-28 03:11 PDT, Sanghyup Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sanghyup Lee
Comment 1 2013-06-27 22:14:32 PDT
Created attachment 205664 [details] Patch
Gyuyoung Kim
Comment 2 2013-06-27 22:19:13 PDT
Comment on attachment 205664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205664&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html
Sanghyup Lee
Comment 3 2013-06-27 22:56:56 PDT
Created attachment 205667 [details] Patch
Chris Dumez
Comment 4 2013-06-27 23:55:08 PDT
Comment on attachment 205667 [details] Patch There are several other similar cases in ScrollView.cpp, why not fix them as well?
Sanghyup Lee
Comment 5 2013-06-28 00:43:35 PDT
Created attachment 205675 [details] Patch
Sanghyup Lee
Comment 6 2013-06-28 02:25:33 PDT
(In reply to comment #4) > (From update of attachment 205667 [details]) > There are several other similar cases in ScrollView.cpp, why not fix them as well? OK. I had fixed it.
Chris Dumez
Comment 7 2013-06-28 02:41:43 PDT
Comment on attachment 205675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205675&action=review Looks fine. r=me with nit. > Source/WebCore/ChangeLog:8 > + Remove a redundant call in ScrollView.cpp nit: "redundant hostWindow() calls".
Sanghyup Lee
Comment 8 2013-06-28 03:11:33 PDT
Created attachment 205687 [details] Patch for landing
WebKit Commit Bot
Comment 9 2013-06-28 04:14:55 PDT
Comment on attachment 205687 [details] Patch for landing Clearing flags on attachment: 205687 Committed r152161: <http://trac.webkit.org/changeset/152161>
WebKit Commit Bot
Comment 10 2013-06-28 04:14:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.