Bug 118168 - Avoid duplicating hostWindow() call in ScrollView.cpp
Summary: Avoid duplicating hostWindow() call in ScrollView.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-27 22:06 PDT by Sanghyup Lee
Modified: 2013-06-28 04:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.79 KB, patch)
2013-06-27 22:14 PDT, Sanghyup Lee 		no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2013-06-27 22:56 PDT, Sanghyup Lee 		no flags Details | Formatted Diff | Diff
Patch (6.83 KB, patch)
2013-06-28 00:43 PDT, Sanghyup Lee 		no flags Details | Formatted Diff | Diff
Patch for landing (6.85 KB, patch)
2013-06-28 03:11 PDT, Sanghyup Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sanghyup Lee 2013-06-27 22:06:46 PDT 
Patch follows.
Comment 1 Sanghyup Lee 2013-06-27 22:14:32 PDT 
Created attachment 205664 [details]
Patch
Comment 2 Gyuyoung Kim 2013-06-27 22:19:13 PDT 
Comment on attachment 205664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205664&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html
Comment 3 Sanghyup Lee 2013-06-27 22:56:56 PDT 
Created attachment 205667 [details]
Patch
Comment 4 Chris Dumez 2013-06-27 23:55:08 PDT 
Comment on attachment 205667 [details]
Patch

There are several other similar cases in ScrollView.cpp, why not fix them as well?
Comment 5 Sanghyup Lee 2013-06-28 00:43:35 PDT 
Created attachment 205675 [details]
Patch
Comment 6 Sanghyup Lee 2013-06-28 02:25:33 PDT 
(In reply to comment #4)
> (From update of attachment 205667 [details])
> There are several other similar cases in ScrollView.cpp, why not fix them as well?

OK. I had fixed it.
Comment 7 Chris Dumez 2013-06-28 02:41:43 PDT 
Comment on attachment 205675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205675&action=review

Looks fine. r=me with nit.

> Source/WebCore/ChangeLog:8
> +        Remove a redundant call in ScrollView.cpp

nit: "redundant hostWindow() calls".
Comment 8 Sanghyup Lee 2013-06-28 03:11:33 PDT 
Created attachment 205687 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2013-06-28 04:14:55 PDT 
Comment on attachment 205687 [details]
Patch for landing

Clearing flags on attachment: 205687

Committed r152161: <http://trac.webkit.org/changeset/152161>
Comment 10 WebKit Commit Bot 2013-06-28 04:14:58 PDT 
All reviewed patches have been landed.  Closing bug.