Bug 118163 – Audio in apps which embed WebViews is corrupted.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Audio in apps which embed WebViews is corrupted.

[Jer Noble]

Created attachment 205663 [details]
Patch

[Jer Noble]

<rdar://problem/14083280>

[Eric Carlson]

Comment on attachment 205663 [details]
Patch

Looks good to me, but I am not a WK2 owner so someone else will have to r+.

[Anders Carlsson]

Why does this need to be a setting? Isn't it something we'd want to work for all apps?

[Jer Noble]

(In reply to comment #4)
> Why does this need to be a setting? Isn't it something we'd want to work for all apps?

Originally it did.  However, some audio intensive apps which embedded a WebView were unhappy to find that the global audio buffer setting had been changed to a very high value.  The easiest way for an embedding app to signal that it's fine with this behavior is through a setting.

[Jer Noble]

Though perhaps this should default to TRUE for WebKit2 and FALSE for WebKit1, since in the WebKit2 case, we can be reasonably confident that there are no other sources of audio apart from <audio>, <video>, and Web Audio.

[Build Bot]

Comment on attachment 205663 [details]
Patch

Attachment 205663 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/995441

New failing tests:
fast/forms/select/popup-closes-on-blur.html

[Build Bot]

Created attachment 205720 [details]
Archive of layout-test-results from APPLE-EWS-5 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-5  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Jer Noble]

(In reply to comment #7)
> (From update of attachment 205663 [details])
> Attachment 205663 [details] did not pass win-ews (win):
> Output: http://webkit-queues.appspot.com/results/995441
> 
> New failing tests:
> fast/forms/select/popup-closes-on-blur.html

Seems unrelated. :)

[Maciej Stachowiak]

Comment on attachment 205663 [details]
Patch

This way of doing it seems ok to me, but if you want to make it have opposite defaults for WK1 and WK2, that would be fine as well.

[Sam Weinig]

Does this really have to be a global?  Is there a reason the places where we read this setting can't access settings or some proxy for it?

[Radar WebKit Bug Importer]

<rdar://problem/14317560>

[Jer Noble]

Committed r152234: <http://trac.webkit.org/changeset/152234>