Bug 118160 – Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Roger Fong]

Implement the IAccessibilityDelegate implemented added in http://trac.webkit.org/changeset/152119

[Roger Fong]

Created attachment 205652 [details]
patch

[WebKit Commit Bot]

Attachment 205652 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/WinLauncher/AccessibilityDelegate.cpp', u'Tools/WinLauncher/AccessibilityDelegate.h', u'Tools/WinLauncher/WinLauncher.cpp', u'Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj', u'Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters']" exit_code: 1
Tools/WinLauncher/AccessibilityDelegate.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Tools/WinLauncher/AccessibilityDelegate.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Roger Fong]

(In reply to comment #2)
> Attachment 205652 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/WinLauncher/AccessibilityDelegate.cpp', u'Tools/WinLauncher/AccessibilityDelegate.h', u'Tools/WinLauncher/WinLauncher.cpp', u'Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj', u'Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters']" exit_code: 1
> Tools/WinLauncher/AccessibilityDelegate.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
> Tools/WinLauncher/AccessibilityDelegate.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Don't think we need config.h here...

[Brent Fulgham]

Comment on attachment 205652 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205652&action=review

r=me.

>> Tools/WinLauncher/AccessibilityDelegate.cpp:26
>> +#include "stdafx.h"
> 
> Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]

We should file a bug against style-check for StdAfx.h support.

[Roger Fong]

> > 
> > Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
> 
> We should file a bug against style-check for StdAfx.h support.

Yeah, I feel like there are a lot of random little Windows only file things that the style checker complains about that we should start tracking. 
I think we do two indents for COM interface method parameters or something and it doesn't like that either.

[Roger Fong]

http://trac.webkit.org/changeset/152171