Bug 118144 - Fix the CLoop LLINT build on the FTL branch
Summary: Fix the CLoop LLINT build on the FTL branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-27 12:25 PDT by Mark Hahnenberg
Modified: 2013-07-11 17:01 PDT (History)
1 user (show)

See Also:


Attachments
the patch (6.67 KB, patch)
2013-07-11 16:52 PDT, Mark Lam
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-06-27 12:25:40 PDT
We should probably fix this.
Comment 1 Mark Lam 2013-07-11 16:52:49 PDT
Created attachment 206496 [details]
the patch
Comment 2 Mark Hahnenberg 2013-07-11 16:57:29 PDT
Comment on attachment 206496 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206496&action=review

r=me with comment.

> Source/JavaScriptCore/runtime/Structure.cpp:36
> +#include <wtf/CommaPrinter.h>

Do we need this?
Comment 3 Mark Lam 2013-07-11 16:58:28 PDT
(In reply to comment #2)
> (From update of attachment 206496 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206496&action=review
> 
> r=me with comment.
> 
> > Source/JavaScriptCore/runtime/Structure.cpp:36
> > +#include <wtf/CommaPrinter.h>
> 
> Do we need this?

I added it because the compiler was complaining without it.  So, yes, it's needed.
Comment 4 Mark Hahnenberg 2013-07-11 16:58:57 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 206496 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=206496&action=review
> > 
> > r=me with comment.
> > 
> > > Source/JavaScriptCore/runtime/Structure.cpp:36
> > > +#include <wtf/CommaPrinter.h>
> > 
> > Do we need this?
> 
> I added it because the compiler was complaining without it.  So, yes, it's needed.

Fair enough, sounds good!
Comment 5 Mark Lam 2013-07-11 17:01:41 PDT
Landed in r152581: <http://trac.webkit.org/changeset/152581>.