RESOLVED FIXED 118128
[webkitpy] AbstractPatchSequencingCommand should have _prepare_state 
https://bugs.webkit.org/show_bug.cgi?id=118128
Summary [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
Csaba Osztrogonác
Reported 2013-06-27 05:36:00 PDT
AbstractSequencedCommand already has _prepare_state method to let its subclasses to prepare an initial state, set options, etc. for example: queries.py/SuggestReviewers, download.py/Clean,Build,Land Unfortunately AbstractPatchSequencingCommand doesn't have _prepare_state method to do similar things, we can only use prepare_steps. But it's overkiller to implement new steps for trivial things, like setting an option. It is a dependency for the new run-tests-touched-by-attachment command, see https://bugs.webkit.org/show_bug.cgi?id=117831#c3 for details.
Attachments
Patch (2.22 KB, patch)
2013-06-27 05:42 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-06-27 05:42:34 PDT
Created attachment 205595 [details] Patch
Peter Gal
Comment 2 2013-06-27 06:36:51 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review > Tools/ChangeLog:10 > + (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps. you mean prepare_sequence instead of the prepare_steps?
Ryosuke Niwa
Comment 3 2013-06-27 09:15:57 PDT
Comment on attachment 205595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review > Tools/ChangeLog:7 > + You should probably mention that this is a preparation to fix some other bug.
Csaba Osztrogonác
Comment 4 2013-06-27 10:50:40 PDT
Committed r152113: <http://trac.webkit.org/changeset/152113>
Note You need to log in before you can comment on or make changes to this bug.