Adds "for (in i object)" loop support in DFG.
Created attachment 205593 [details] Adds "for (in i object)" loop support in DFG.
Attachment 205593 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/Opcode.h', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/dfg/DFGAbstractState.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGCapabilities.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGOperations.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm', u'Source/JavaScriptCore/llint/LowLevelInterpreter64.asm', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.h', u'Source/JavaScriptCore/runtime/StructureChain.h']" exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 205601 [details] Fixed style problems
Comment on attachment 205601 [details] Fixed style problems Attachment 205601 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/998082 New failing tests: fast/js/global-constructors-attributes-shared-worker.html fast/js/global-constructors-attributes-dedicated-worker.html
Created attachment 205629 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment on attachment 205601 [details] Fixed style problems Attachment 205601 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1016091 New failing tests: http/tests/inspector/extensions-headers.html inspector/console/console-format.html inspector/console/console-format-style-whitelist.html http/tests/inspector/inspect-element.html inspector/styles/styles-computed-trace.html
Created attachment 205823 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Comment on attachment 205601 [details] Fixed style problems Attachment 205601 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1022423 New failing tests: inspector/console/console-format-style.html inspector/console/console-format.html http/tests/inspector/extensions-ignore-cache.html http/tests/inspector/inspect-element.html
Created attachment 206060 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Comment on attachment 205601 [details] Fixed style problems Old bug cleanup… Please rebase, fix the test failures and submit a new patch.
Created attachment 218207 [details] Adds "for-in" statement support in DFG
Rebased and fixed. Could someone review please?
It looks like "for..in" support was added to the DFG in bug 134142: https://bugs.webkit.org/show_bug.cgi?id=134142 Lets duplicate and clear patch review flags. *** This bug has been marked as a duplicate of bug 134142 ***