Bug 118124 - Use consistent file names for WidgetBackingStoreGtkX11 class
Summary: Use consistent file names for WidgetBackingStoreGtkX11 class
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
Depends on:
Reported: 2013-06-27 04:12 PDT by Iago Toral
Modified: 2013-06-27 06:32 PDT (History)
3 users (show)

See Also:

Patch (14.79 KB, patch)
2013-06-27 04:21 PDT, Iago Toral
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Iago Toral 2013-06-27 04:12:56 PDT
WidgetBackingStoreGtkX11 class is defined in a file named GtkWidgetBackingStoreX11.{cpp,h}, these files should be renamed to match the class name to keep consistency.
I will attach a patch for this shortly.
Comment 1 Iago Toral 2013-06-27 04:21:51 PDT
Created attachment 205584 [details]

Renames affected files to match class names.
Comment 2 Carlos Garcia Campos 2013-06-27 05:23:51 PDT
Comment on attachment 205584 [details]

Makes sense
Comment 3 WebKit Commit Bot 2013-06-27 05:31:01 PDT
Comment on attachment 205584 [details]

Rejecting attachment 205584 [details] from commit-queue.

itoral@igalia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Commit Bot 2013-06-27 06:32:06 PDT
Comment on attachment 205584 [details]

Clearing flags on attachment: 205584

Committed r152094: <http://trac.webkit.org/changeset/152094>
Comment 5 WebKit Commit Bot 2013-06-27 06:32:08 PDT
All reviewed patches have been landed.  Closing bug.