WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118124
Use consistent file names for WidgetBackingStoreGtkX11 class
https://bugs.webkit.org/show_bug.cgi?id=118124
Summary
Use consistent file names for WidgetBackingStoreGtkX11 class
Iago Toral
Reported
2013-06-27 04:12:56 PDT
WidgetBackingStoreGtkX11 class is defined in a file named GtkWidgetBackingStoreX11.{cpp,h}, these files should be renamed to match the class name to keep consistency. I will attach a patch for this shortly.
Attachments
Patch
(14.79 KB, patch)
2013-06-27 04:21 PDT
,
Iago Toral
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Iago Toral
Comment 1
2013-06-27 04:21:51 PDT
Created
attachment 205584
[details]
Patch Renames affected files to match class names.
Carlos Garcia Campos
Comment 2
2013-06-27 05:23:51 PDT
Comment on
attachment 205584
[details]
Patch Makes sense
WebKit Commit Bot
Comment 3
2013-06-27 05:31:01 PDT
Comment on
attachment 205584
[details]
Patch Rejecting
attachment 205584
[details]
from commit-queue.
itoral@igalia.com
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 4
2013-06-27 06:32:06 PDT
Comment on
attachment 205584
[details]
Patch Clearing flags on attachment: 205584 Committed
r152094
: <
http://trac.webkit.org/changeset/152094
>
WebKit Commit Bot
Comment 5
2013-06-27 06:32:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug