Bug 118120 - [CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
Summary: [CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-27 01:32 PDT by Patrick R. Gansterer
Modified: 2013-07-04 01:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2013-06-27 01:40 PDT, Patrick R. Gansterer 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-06-27 01:32:33 PDT 
[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
Comment 1 Patrick R. Gansterer 2013-06-27 01:40:45 PDT 
Created attachment 205574 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2013-06-30 09:41:10 PDT 
Comment on attachment 205574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205574&action=review

LGTM.

> Source/JavaScriptCore/CMakeLists.txt:540
>  add_definitions(-DBUILDING_JavaScriptCore)
> +add_definitions(-DSTATICALLY_LINKED_WITH_WTF)

You could merge these into a single call.
Comment 3 Gyuyoung Kim 2013-06-30 19:07:49 PDT 
Comment on attachment 205574 [details]
Patch

Looks fine too.
Comment 4 Patrick R. Gansterer 2013-07-04 01:55:10 PDT 
Committed r152393: <http://trac.webkit.org/changeset/152393>