Bug 118115 - Avoid duplicating hostWindow() call in FrameView::setFrameRect()
Summary: Avoid duplicating hostWindow() call in FrameView::setFrameRect()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-26 22:09 PDT by Seokju Kwon
Modified: 2013-06-27 08:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2013-06-26 22:11 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2013-06-27 06:50 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-06-26 22:09:52 PDT 
Patch follows.
Comment 1 Seokju Kwon 2013-06-26 22:11:40 PDT 
Created attachment 205561 [details]
Patch
Comment 2 Chris Dumez 2013-06-27 04:21:35 PDT 
Comment on attachment 205561 [details]
Patch

FrameView::hostWindow() is not trivial/inlined so ok. r=me.
Comment 3 Chris Dumez 2013-06-27 04:22:04 PDT 
Comment on attachment 205561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205561&action=review

> Source/WebCore/ChangeLog:7
> +

Please add a Changelog.
Comment 4 Seokju Kwon 2013-06-27 06:50:55 PDT 
Created attachment 205598 [details]
Patch
Comment 5 Seokju Kwon 2013-06-27 06:51:30 PDT 
Comment on attachment 205598 [details]
Patch

Fixed it. Thanks!
Comment 6 WebKit Commit Bot 2013-06-27 08:12:09 PDT 
Comment on attachment 205598 [details]
Patch

Clearing flags on attachment: 205598

Committed r152098: <http://trac.webkit.org/changeset/152098>
Comment 7 WebKit Commit Bot 2013-06-27 08:12:11 PDT 
All reviewed patches have been landed.  Closing bug.