Bug 118109 - [Mac] Add Mavericks system font to Test systems
Summary: [Mac] Add Mavericks system font to Test systems
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Depends on:
Reported: 2013-06-26 18:15 PDT by Dean Jackson
Modified: 2013-06-27 18:03 PDT (History)
4 users (show)

See Also:

Patch (4.14 KB, patch)
2013-06-26 18:19 PDT, Dean Jackson
simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-06-26 18:15:46 PDT
OS X Mavericks uses a different font for system controls. We need to make sure our test systems know about it otherwise they'll use a fallback font. Unfortunately the fonts are hidden, so we'll have to add them directly rather than find them in the list of available fonts.

Comment 1 Dean Jackson 2013-06-26 18:19:42 PDT
Created attachment 205552 [details]
Comment 2 Build Bot 2013-06-26 18:40:32 PDT
Comment on attachment 205552 [details]

Attachment 205552 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/944242
Comment 3 Build Bot 2013-06-26 19:01:40 PDT
Comment on attachment 205552 [details]

Attachment 205552 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/977466
Comment 4 Jessie Berlin 2013-06-27 11:54:22 PDT
/Volumes/Data/EWS/WebKit/Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:164:12: error: use of undeclared identifier 'fontFamiliySet'; did you mean 'fontFamilySet'?
    return fontFamiliySet;
/Volumes/Data/EWS/WebKit/Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:45:19: note: 'fontFamilySet' declared here
    static NSSet *fontFamilySet = [[NSSet setWithObjects:
1 error generated.

Please fix before committing :)
Comment 5 Dean Jackson 2013-06-27 18:03:00 PDT
Committed r152144: <http://trac.webkit.org/changeset/152144>