RESOLVED FIXED 118108
Deprecate StringImpl::charactersWithNullTermination 
https://bugs.webkit.org/show_bug.cgi?id=118108
Summary Deprecate StringImpl::charactersWithNullTermination
Anders Carlsson
Reported 2013-06-26 17:58:09 PDT
Deprecate StringImpl::charactersWithNullTermination
Attachments
Patch (62.13 KB, patch)
2013-06-26 18:02 PDT, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-06-26 18:02:23 PDT
Created attachment 205550 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-26 18:05:41 PDT
Attachment 205550 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/text/WTFString.cpp', u'Source/WTF/wtf/text/WTFString.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/WebGLProgram.cpp', u'Source/WebCore/platform/graphics/win/FontCacheWin.cpp', u'Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp', u'Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp', u'Source/WebCore/platform/graphics/win/IconWin.cpp', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/platform/graphics/wince/FontPlatformData.cpp', u'Source/WebCore/platform/network/curl/CurlDownload.cpp', u'Source/WebCore/platform/network/win/CookieJarWin.cpp', u'Source/WebCore/platform/network/win/DownloadBundleWin.cpp', u'Source/WebCore/platform/network/win/ResourceHandleWin.cpp', u'Source/WebCore/platform/sql/SQLiteFileSystem.cpp', u'Source/WebCore/platform/sql/SQLiteStatement.cpp', u'Source/WebCore/platform/text/win/LocaleWin.cpp', u'Source/WebCore/platform/text/win/TextCodecWin.cpp', u'Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp', u'Source/WebCore/platform/win/ContextMenuWin.cpp', u'Source/WebCore/platform/win/DragImageWin.cpp', u'Source/WebCore/platform/win/FileSystemWin.cpp', u'Source/WebCore/platform/win/MIMETypeRegistryWin.cpp', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebCore/platform/win/PathWalker.cpp', u'Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp', u'Source/WebCore/platform/win/SharedBufferWin.cpp', u'Source/WebCore/platform/wince/FileSystemWinCE.cpp', u'Source/WebCore/plugins/win/PluginDatabaseWin.cpp', u'Source/WebCore/plugins/win/PluginPackageWin.cpp', u'Source/WebCore/plugins/win/PluginViewWin.cpp', u'Source/WebKit/win/COMPropertyBag.h', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp', u'Source/WebKit/win/WebDownloadCFNet.cpp', u'Source/WebKit/win/WebKitSystemBits.cpp', u'Source/WebKit/win/WebLocalizableStrings.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/DumpRenderTree.cpp']" exit_code: 1 Source/WebCore/platform/network/win/ResourceHandleWin.cpp:310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/win/FontCacheWin.cpp:103: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/graphics/win/FontCacheWin.cpp:105: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/plugins/win/PluginViewWin.cpp:900: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/sql/SQLiteStatement.cpp:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-06-26 18:08:31 PDT
Committed r152069: <http://trac.webkit.org/changeset/152069>
Note You need to log in before you can comment on or make changes to this bug.