Bug 118105 – Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[James Craig]

Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs

I count at least four sets of tabs: 2 in the main toolbar, 1 in the console toolbar, and 1 in the element Styles inspector.

[Radar WebKit Bug Importer]

<rdar://problem/14283943>

[Timothy Hatcher]

What is the definition of tab and tab list?

[James Craig]

Those are ARIA roles.
http://www.w3.org/WAI/PF/aria/complete#tab
http://www.w3.org/WAI/PF/aria/complete#tablist

[James Craig]

Styles Inspector tab fixed as part of the patch for bug 118105, so this one should just cover the main tabs, and any others that still aren't fixed.

[James Craig]

Typo: Above reference should read …as part of the patch for bug 118104, not 118105.

[James Craig]

Created attachment 208883 [details]
patch

[Joseph Pecoraro]

Comment on attachment 208883 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208883&action=review

r=me

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:33
> +

Style: Remove this extra blank line.

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:64
> +            if (this._role == "tab")

Style: In Web Inspector we use strict equality `===` whenever possible.

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:69
> +            if (this._role == "tab")

===

> Source/WebInspectorUI/UserInterface/Toolbar.js:38
> +    this._leftSectionElement.setAttribute('role', 'tablist');

Style: In Web Inspector we use double quoted strings whenever possible. "role" / "tablist".

> Source/WebInspectorUI/UserInterface/Toolbar.js:47
> +    this._rightSectionElement.setAttribute('role', 'tablist');

"…"

[James Craig]

(In reply to comment #7)
> Style: In Web Inspector we use double quoted strings whenever possible. "role" / "tablist".

Do you think this is worth updating the check-webkit-style script?

[James Craig]

(In reply to comment #8)
> Do you think this is worth updating the check-webkit-style script?

bug 118105

[James Craig]

(In reply to comment #8)

> Do you think this is worth updating the check-webkit-style script?

Oops. Bug 119901.

[James Craig]

Created attachment 208932 [details]
patch with review feedback

[WebKit Commit Bot]

Comment on attachment 208932 [details]
patch with review feedback

Rejecting attachment 208932 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[James Craig]

commit‑queue?

[chris fleizach]

Comment on attachment 208932 [details]
patch with review feedback

Real review by Joe, but setting the flag to make it through commit bot

[WebKit Commit Bot]

Comment on attachment 208932 [details]
patch with review feedback

Clearing flags on attachment: 208932

Committed r154196: <http://trac.webkit.org/changeset/154196>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.