RESOLVED FIXED 118093
Kill updateStyleForAllDocuments()
https://bugs.webkit.org/show_bug.cgi?id=118093
Summary Kill updateStyleForAllDocuments()
Simon Fraser (smfr)
Reported 2013-06-26 15:29:32 PDT
There is no reason we should ever have to call Document::updateStyleForAllDocuments(), yet JSCallbackData::invokeCallback() and JSCustomXPathNSResolver::lookupNamespaceURI() both do so.
Attachments
Patch (2.76 KB, patch)
2013-07-29 22:23 PDT, Simon Fraser (smfr)
ggaren: review+
Simon Fraser (smfr)
Comment 1 2013-07-29 22:11:23 PDT
I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live.
Simon Fraser (smfr)
Comment 2 2013-07-29 22:14:51 PDT
(In reply to comment #1) > I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live. Actually it's just flakey. It fails without any change.
Simon Fraser (smfr)
Comment 3 2013-07-29 22:23:39 PDT
Simon Fraser (smfr)
Comment 4 2013-07-29 22:31:17 PDT
This patch removes the callers. If it passes EWS I'll remove the function too.
Geoffrey Garen
Comment 5 2013-07-29 23:32:15 PDT
Comment on attachment 207687 [details] Patch r=me
Alexey Proskuryakov
Comment 6 2013-07-30 10:27:47 PDT
See also: bug 46761. Good to hear that tests are no longer failing, although EWS is in such shape that it probably won’t provide a trustworthy answer. Looks like we still have a caller in Element::setActive()?
Alexey Proskuryakov
Comment 7 2013-07-30 10:29:27 PDT
See also discussion in bug 32580.
Simon Fraser (smfr)
Comment 8 2013-07-30 10:42:58 PDT
Simon Fraser (smfr)
Comment 9 2013-08-08 17:46:51 PDT
Note You need to log in before you can comment on or make changes to this bug.