Bug 118093 - Kill updateStyleForAllDocuments()
Summary: Kill updateStyleForAllDocuments()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-26 15:29 PDT by Simon Fraser (smfr)
Modified: 2013-08-08 17:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2013-07-29 22:23 PDT, Simon Fraser (smfr) 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-06-26 15:29:32 PDT 
There is no reason we should ever have to call Document::updateStyleForAllDocuments(), yet JSCallbackData::invokeCallback() and JSCustomXPathNSResolver::lookupNamespaceURI() both do so.
Comment 1 Simon Fraser (smfr) 2013-07-29 22:11:23 PDT 
I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live.
Comment 2 Simon Fraser (smfr) 2013-07-29 22:14:51 PDT 
(In reply to comment #1)
> I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live.

Actually it's just flakey. It fails without any change.
Comment 3 Simon Fraser (smfr) 2013-07-29 22:23:39 PDT 
Created attachment 207687 [details]
Patch
Comment 4 Simon Fraser (smfr) 2013-07-29 22:31:17 PDT 
This patch removes the callers. If it passes EWS I'll remove the function too.
Comment 5 Geoffrey Garen 2013-07-29 23:32:15 PDT 
Comment on attachment 207687 [details]
Patch

r=me
Comment 6 Alexey Proskuryakov 2013-07-30 10:27:47 PDT 
See also: bug 46761. Good to hear that tests are no longer failing, although EWS is in such shape that it probably won’t provide a trustworthy answer.

Looks like we still have a caller in Element::setActive()?
Comment 7 Alexey Proskuryakov 2013-07-30 10:29:27 PDT 
See also discussion in bug 32580.
Comment 8 Simon Fraser (smfr) 2013-07-30 10:42:58 PDT 
http://trac.webkit.org/changeset/42384 is related.
Comment 9 Simon Fraser (smfr) 2013-08-08 17:46:51 PDT 
https://trac.webkit.org/r153872